Bismuth subcarbonate and graphite carbon nitride(g-C3N4) as novel photocatalysts have been attracted wide attention in recent years. In this review, preparation and modification methods of bismuth subcarbonate and g-C3N4 are systematically introduced. Moreover, nonmetallic elements doping, heterostructure constructing and metal decorating on the surface are broadly applied in bismuth subcarbonate modification. At the same time, morphological controlling and element doping of g-C3N4 together with g-C3N4 composites are attracted massive studies. Finally, the development of bismuth subcarbonate and g-C3N4 is discussed and opinions on future trend are presented as well.